ci: limit release-please releasable sections#881
Merged
Conversation
![aao-ipr-bot[bot]](https://avatars.githubusercontent.com/u/134922?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM. Tight fix for the right problem — manifest mode started honoring the config and the broad section list let ci:/chore: commits cut betas.
Things I checked
release-please-config.json:17-22— releasable set is nowfeat,fix,perf,revert,deps. In release-please v5,changelog-sectionsextends the recognized commit types beyond thefeat/fix/perfdefaults, so removingci/build/chore/docs/style/refactor/testdoes stop those types from triggering a release PR — not just hiding them from the changelog. The empirical trigger (#879 was aci:commit, manifest at6.3.0-beta.4) confirms the diagnosis..github/workflows/release-please.yml:22-27— workflow consumes the config as-is; no other commit-type gating elsewhere..release-please-manifest.json— clean, prerelease beta channel intact.
Follow-ups (non-blocking — file as issues)
- Dependabot's default commit prefix is
build(deps):, not baredeps:. Ifdepshere is meant to catch Dependabot PRs, drop a.github/dependabot.ymlwithcommit-message: { prefix: \"deps\" }— otherwise the new section is decorative. RELEASING.md:110-118still listsdocs:/chore:/refactor:/test:/style:/ci:as valid types without flagging that they'll be silently dropped from the changelog under this config. Worth a one-line note so contributors don't expect theirdocs:PR to show up.
Safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat,fix,perf,revert, anddeps.ci,build,chore,docs,style,refactor, andtestfrom configured release sections so manifest mode does not cut PyPI betas for infrastructure-only commits.Why
After manifest mode started honoring the repository config, CI-only commits opened a beta release PR. The beta number was correct, but the trigger was too broad for package publishing.
Validation
python3 -c 'import json; json.load(open("release-please-config.json"))'git diff --checkgit commit